extend and fix data url imports #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
romainmenke
commented
Jul 20, 2023
•
romainmenke
commented
- add support for url encoded data urls
- fix handling of embedded relative imports
romainmenke
commented
Jul 20, 2023
| @@ -1,24 +1,6 @@ | |||
| p { color: green; } | |||
| @import url(foo.css);p { color: green; }p { color: blue; }@media (min-width: 320px){@layer foo{ | |||
There was a problem hiding this comment.
If a data url eventually unfurls into a regular import with a relative path it should stop and must not inline the relative import.
Each import is resolved relatively to it's parent and when the parent is a data url there isn't any domain or base url to resolve a url against.
I think usage of data urls was already very niche and that it is extremely unlikely that anyone depends on the old behavior.
…-url-imports--adventurous-uakari-79de749a0a
RyanZim
approved these changes
Jul 22, 2023
lib/parse-styles.js
Outdated
Comment on lines
97
to
99
| if (dataURL.isValid(stmt.from)) { | ||
| return | ||
| } |
There was a problem hiding this comment.
Perhaps leave a comment on what we're doing here, and why? Won't be obvious to our future selves.
|
Thank you for the review 🙇 |
romainmenke
deleted the
extend-and-fix-data-url-imports--adventurous-uakari-79de749a0a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.